Message info
 
To:yselkowitz@users.sourceforge.net From:Mark Kettenis Subject:Re: [PATCH xserver 2/2] xfree86: add support for Cygwin Date:Thu, 29 Mar 2012 08:33:42 +0200 (CEST)
 

> Date: Wed, 28 Mar 2012 23:05:51 -0500
> From: "Yaakov (Cygwin/X)" <yselkowitz@users.sourceforge.net>
>
> On 2012-03-28 22:19, Alan Coopersmith wrote:
> > On 03/27/12 10:16 PM, Yaakov (Cygwin/X) wrote:
> >> +
> >> +i2c/libi2c.la:
> >> + $(MAKE) -C $(@D) $(@F)
> >> +
> >> +dixmods/libdixmods.la:
> >> + $(MAKE) -C $(@D) $(@F)
> >> +
> >> +dixmods/libxorgxkb.la:
> >> + $(MAKE) -C $(@D) $(@F)
> >
> > Should those be $(MAKE) $(AM_MAKEFLAGS) ... ? That's what most automake calls
> > seem to use.
> > Also -C is a gnu make specific flag, but I think we still require GNU make
> > to build the server due to other issues anyway.

The server builds fine with (Open)BSD make, and we'd like to keep it
that way. And it doesn't support -C.
>
> $(MAKE) -C is already used in the top-level Makefile, hw/Makefile, and
> hw/kdrive/Makefile. But now that you mention it, I see that I forgot
> the $(AM_V_at).

It's only used for the "relink" target, which isn't actually used for
a normal build. And it bears a "gross hack" comment in the toplevel
Makefile. Can you solve this in a different way? Or perhaps explain
the problem you're trying to solve? Including "." in SUBDIRS seems
like a gross hack to me as well.
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel