Message info
 
To:Laxman Dewangan From:Stephen Warren Subject:Re: [PATCH V4 2/2] staging: iio: add driver for isl29028 Date:Thu, 12 Apr 2012 09:36:37 -0600
 

On 04/12/2012 08:01 AM, Laxman Dewangan wrote:
> Intersil's ISL29028 is concurrent Ambient Light and
> Proximity Sensor device.
> Add driver to access the light and IR intensity and

> +static const struct regmap_config isl29028_regmap_config = {
...
> + .max_register = ISL29028_MAX_REGS - 1,
> + .num_reg_defaults_raw = ISL29028_MAX_REGS,

This should really be ISL29028_NUM_REGS, since you don't have a maximum
number of registers, just a number of regs.

However, if there's no other reason to respin the patch, don't worry
about it.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel