Message info
 
To:Jekyll Wu From:Kurt Hindenburg Subject:Re: [Konsole-devel] Review Request: Add script for migrating tabbar and menubar options from default profile Date:Sun, 18 Mar 2012 15:22:24 -0000
 

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104253/

Ship it!

If it works for you go ahead - I would have hoped this could have been done w/ less code - oh well - thanks

- Kurt


On March 14th, 2012, 12:45 p.m., Jekyll Wu wrote:

http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
Review request for Konsole.
By Jekyll Wu.

Updated March 14, 2012, 12:45 p.m.

Description

The bug report has described the problem quite clear.

The script is quite stupid, and I hope it is stupid enough to be easily reviewed.

A possile issure is where to organize the kconf-update related stuff in the repository. I put it under data/updaters/. Not sure whether that is a good place.

Testing

It works with the exsiting KDE/4.8 branch
Bugs: 293231

Diffs

  • data/CMakeLists.txt (2b8dd95)
  • data/updaters/CMakeLists.txt (PRE-CREATION)
  • data/updaters/konsole-2.9.0-global-options.sh (PRE-CREATION)
  • data/updaters/konsole.upd (PRE-CREATION)

View Diff