Message info
 
To:Akarsh Simha From:Rafal Kulaga Subject:Re: [Kstars-devel] Review Request: Fix dissapearing Milky Way at high zoomlevel on QPainter Date:Sun, 18 Mar 2012 16:42:45 -0000
 

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104320/

Ship it!

OK, this patch works for me on both backends. You can commit it to the master branch.

- Rafal


On March 18th, 2012, 7:45 a.m., Rishab Arora wrote:

http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
Review request for KStars, Rafal Kulaga and Akarsh Simha.
By Rishab Arora.

Updated March 18, 2012, 7:45 a.m.

Description

Fixes bug https://bugs.kde.org/show_bug.cgi?id=266929 for QPainter backend only.
At high zoomlevel, the points leave the FOV and are ignored completely, whereas their fill should not be.
Used clipping in QPainter to fix bug.

Testing

Tested at various zoomlevels and resolutions. No issues found.

Diffs

  • kstars/projections/projector.h (966d002)
  • kstars/projections/projector.cpp (e8c1aff)
  • kstars/skyqpainter.cpp (43f06e8)

View Diff