Message info
 
To: From:Django Subject:Re: [Django] #17144: Excessive GROUP BY clauses during aggregations. Date:Thu, 29 Mar 2012 06:36:42 -0000
 

#17144: Excessive GROUP BY clauses during aggregations.
----------------------------------+------------------------------------
Reporter: christian_oudard | Owner: akaariai
Type: Bug | Status: new
Component: ORM aggregation | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------

Comment (by aaugustin):

The `aggregation_regress` tests pass under Oracle with this patch:

{{{
Running tests...
----------------------------------------------------------------------
..s....s....................s..
----------------------------------------------------------------------
Ran 31 tests in 12.253s

OK
}}}

However, if the changes to `django.db.models` are reverted,
`test_aggregate_duplicate_columns` doesn't fail:

{{{
----------------------------------------------------------------------
..s....s..............E.....s..
======================================================================
ERROR [0.040s]: test_more_more
(regressiontests.aggregation_regress.tests.AggregationTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/var/lib/jenkins/jobs/Django trunk +
Oracle/workspace/tests/regressiontests/aggregation_regress/tests.py", line
472, in test_more_more
grouping, gb_params = qs.query.get_compiler(qs.db).get_grouping([])
TypeError: get_grouping() takes exactly 1 argument (2 given)

----------------------------------------------------------------------
Ran 31 tests in 11.787s

FAILED (errors=1)
}}}

(It's another test that fails.)

So it appears that the regression test doesn't validate the fix, at least
under Oracle.

--
Ticket URL: <https://code.djangoproject.com/ticket/17144#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to django-updates+unsubscribe@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.