Message info
 
To:kde-commits@kde.org From:Jekyll Wu Subject:[konsole] src: UI string: Edit Font ==> Select Font Date:Mon, 7 May 2012 22:50:14 +0200 (CEST)
 

Git commit e6ba69b36a5ef3731464b8d86c56f2e95f53061a by Jekyll Wu.
Committed on 07/05/2012 at 22:27.
Pushed by jekyllwu into branch 'master'.

UI string: Edit Font ==> Select Font

It feels strange and misleading to use "Edit". Clearly konsole won't
modify the listed fonts.

M +1 -1 src/EditProfileDialog.cpp
M +3 -3 src/EditProfileDialog.ui

http://commits.kde.org/konsole/e6ba69b36a5ef3731464b8d86c56f2e95f53061a

diff --git a/src/EditProfileDialog.cpp b/src/EditProfileDialog.cpp
index 6d9c05a..5ad1661 100644
--- a/src/EditProfileDialog.cpp
+++ b/src/EditProfileDialog.cpp
@@ -454,7 +454,7 @@ void EditProfileDialog::setupAppearancePage(const Profile::Ptr profile)

connect(_ui->fontSizeSlider, SIGNAL(valueChanged(int)), this,
SLOT(setFontSize(int)));
- connect(_ui->editFontButton, SIGNAL(clicked()), this,
+ connect(_ui->selectFontButton, SIGNAL(clicked()), this,
SLOT(showFontDialog()));

// setup font smoothing
diff --git a/src/EditProfileDialog.ui b/src/EditProfileDialog.ui
index 28c34d1..8b8e83c 100644
--- a/src/EditProfileDialog.ui
+++ b/src/EditProfileDialog.ui
@@ -487,12 +487,12 @@
</widget>
</item>
<item>
- <widget class="QPushButton" name="editFontButton">
+ <widget class="QPushButton" name="selectFontButton">
<property name="toolTip">
- <string>Change the font used in this profile</string>
+ <string>Select the font used in this profile</string>
</property>
<property name="text">
- <string>Edit Font...</string>
+ <string>Select Font...</string>
</property>
</widget>
</item>