Message info
 
To:KDEPIM From:Till Adam Subject:Re: [Kde-pim] Review Request: KMail: Add dialog for mass-modifying indexing attribute Date:Sun, 18 Mar 2012 15:43:13 -0000
 


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103318/#review11551
-----------------------------------------------------------


I like the idea in general, the approach seems sane. Maybe it could be combined with a suggestion to index a folder once it has been entered a number of times, or other metrics that might indicate "live" folders?

- Till Adam


On Dec. 3, 2011, 9:11 p.m., Will Stephenson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103318/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2011, 9:11 p.m.)
>
>
> Review request for KDEPIM.
>
>
> Description
> -------
>
> This patch adds a button to show a CollectionDialog to the KMail Configure Dialog Misc main tab. The folders where IndexPolicyAttribute is set are selected by default. Changes to the multiple selection cause the mail collections' IndexPolicyAttribute to be modifled.
>
> The intention of this patch is based on the assumption that indexing all mail b default causes performance problems, therefore I propose to reduce the folders to be indexed by default (not in this patch), and to make it easy for users to mass-modify email indexing flags in order to add folders that they do want to index.
>
> It relies on changes in kdepimlibs to Akonadi::CollectionDialog and Akonadi::AsyncSelectionHandler to allow a multiple selection to be supplied as a default, see separate review for those.
>
> The code is still a hacky proof of concept, but please give feedback on the idea.
>
> Problems:
> * There is a trivial logic error in calculating the set of non-indexed-collections
> * CollectionDialog wrecks the multiple selection if the line edit filter is used
> * CollectionDialog immediately accepts the selection on double click.
>
>
> Diffs
> -----
>
> kmail/configuredialog.cpp 9a9a5a4
> kmail/configuredialog_p.h 23aabec
> kmail/ui/miscpagemaintab.ui 3cbefc4
>
> Diff: http://git.reviewboard.kde.org/r/103318/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Dialog added by patch
> http://git.reviewboard.kde.org/r/103318/s/349/
>
>
> Thanks,
>
> Will Stephenson
>
>

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/