Message info
 
To:Telepathy From:Commit Hook Subject:Re: Review Request: Make display name and icon configurable from accounts kcm Date:Fri, 30 Mar 2012 15:58:12 -0000
 

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104323/

This review has been submitted with commit fc25a790547251bcb4aa408d761c5f917bd27d14 by Daniele E. Domenichelli to branch master.

- Commit


On March 30th, 2012, 3:07 p.m., Daniele Elmo Domenichelli wrote:

http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
Review request for Telepathy.
By Daniele Elmo Domenichelli.

Updated March 30, 2012, 3:07 p.m.

Description

There are a few rendering bugs in KWidgetItemDelegate, but the ugliest is fixed in kde 4.8.1, one is fixed in kdelibs KDE/4.8 branch and another one in in review

Testing

Works

Diffs

  • src/CMakeLists.txt (8fb139a673326be47b08c695c13c78d7534d1afb)
  • src/accounts-list-delegate.h (2c8b638ce244c261e9a8a462e3dca93ebd88948a)
  • src/accounts-list-delegate.cpp (e818582ca3bd9b96079b1a0c9f10997b7649caf1)
  • src/change-icon-button.h (PRE-CREATION)
  • src/change-icon-button.cpp (PRE-CREATION)
  • src/edit-display-name-button.h (PRE-CREATION)
  • src/edit-display-name-button.cpp (PRE-CREATION)

View Diff

Screenshots