Message info
 
To:Martin Gräßlin From:Thomas Lübking Subject:Review Request: handle m_currentBuildQuadsIterator validation independent from painting pass Date:Mon, 07 May 2012 20:36:50 -0000
 

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104881/

http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Description

issue is that the effect chain may (will) change between two paint passes and buildQuads is called outside the paint pass
(shadows / decos whatever changes) so that the iterator may dangle

Testing

not encountered the crash but tested and iterator is validated once per buildquads and i got no infinite loop either ;-)
i'll keep this running for a short while before -if- pushing
Bugs: 294451, 299582

Diffs

  • kwin/effects.cpp (27198e9)

View Diff