Message info
 
To:wikibugs-l@lists.wikimedia.org From:bugzilla-daemon@wikimedia.org Subject:[Bug 34453] Extension:NewPageCSS is merely a bugfix which should be merged into existing in-SVN extension PageCSS Date:Sun, 19 Feb 2012 19:49:46 +0000
 

https://bugzilla.wikimedia.org/show_bug.cgi?id=34453

Carl Austin Bennett <carlb613@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|Unprioritized |Normal
Severity|enhancement |normal

--- Comment #1 from Carl Austin Bennett <carlb613@hotmail.com> 2012-02-19 19:49:46 UTC ---
I've looked at the PageCSS/PageCSS.php currently in trunk and it appears that
the only thing which needs to change for it to work correctly is for the parser
tag hook to return a value - a one-line change to return the empty string when
done.

Nothing else which was changed between PageCSS and NewPageCSS actually makes a
difference - whatever restrictions might have been encountered for Unicode in
the description strings were specific to one previous MediaWiki version and
have been resolved, rendering [[mw:extension:NewPageCSS]] unnecessary.

At this point, this is a bug fix for the PageCSS/PageCSS.php currently in
trunk.

public static function parse( $content, array $args, Parser $parser ) {
$css = htmlspecialchars( trim( Sanitizer::checkCss( $content ) ) );
$parser->mOutput->addHeadItem( <<<EOT
<style type="text/css">
/*<![CDATA[*/
{$css}
/*]]>*/
</style>
EOT
);
return htmlspecialchars("");
}

I've changed the status of this item to be a one-line bug fix... not an
enhancement.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l