Message info
 
To:wikibugs-l@lists.wikimedia.org From:bugzilla-daemon@wikimedia.org Subject:[Bug 33928] HTML page title should say we are looking at a diff Date:Sun, 18 Mar 2012 16:02:49 +0000
 

https://bugzilla.wikimedia.org/show_bug.cgi?id=33928

Amir E. Aharoni <amir.aharoni@mail.huji.ac.il> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords|need-review |patch
CC| |amir.aharoni@mail.huji.ac.i
| |l

--- Comment #2 from Amir E. Aharoni <amir.aharoni@mail.huji.ac.il> 2012-03-18 16:02:49 UTC ---
I agree that this is a bug that should be fixed. I also didn't like that the
title of the diff page is the same as of the page itself.

Patch 10238 looks good to me functionally, but:
* wfMessage() is better than wfMsg(), see
https://www.mediawiki.org/wiki/New_messages_API
* setPageTitle() would be better inside showDiffPage()
* Documentation for the new message must be added in MessagesQqq.php. Please
mention that it's the title of the HTML page.
* Please consider adding the message to MessagesAs.php, too :)

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l